-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bevy v0.15.0 #87
base: main
Are you sure you want to change the base?
Bevy v0.15.0 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great!
A few questions, I'm still trying to answer:
- Instead of
<MyHandleComponent>.0
everywhere, I think it would be nicer to use.id()
. This requiresMyComponentHandle
to deriveDeref
andDerefMut
- Is there yet a convention on what to name these newtypes for Handles? I've seen several cases where Bevy renamed them to have "2d" at the end, e.g.
MeshMaterial2d
Another note, which is somewhat unrelated, is that certain logic should be able to be eliminated or optimized with new features in 0.14/0.15. Specifically, the |
AH, one more catch: The |
Regarding the As for the migration to bevy 0.15 features, you're obviously right! However I didn't want to make the PR too big. I figured a first PR could make it work with 0.15 and a second PR could make it more idiomatic :) |
Yes I have the same errors when I run |
I thought I'd chip in a little as I dabbled with this during 0.15 release candidate process, and I remember I was stuck for a few hours on why extracted entities kept piling up duplicates in the render world; As I did not know about this new retained render world feature in 0.15. Unless 1) some sort of resource structure is implemented to keep app world entities and render world entities in sync or 2) spawn extracted entities with the Hope it helps! |
linebender/rfcs#5 led to the agreement that we would commit Cargo.lock. |
#86